Yair Zaslavsky has posted comments on this change. Change subject: core: Get command compatiblity versions query ......................................................................
Patch Set 4: (2 inline comments) Addressing Roy's comments. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/CommandVersionsInfo.java Line 13: this.storagePoolVersion = storagePoolVersion; Roy - not using version class here for several reasons - a. action_version_map uses String, not Version. c. UI addresses versions as string (look at GetConfigurationValueParameters for example) .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ActionGroupDAOWrapperImpl.java Line 47: // TODO Auto-generated method stub Roy - will be converted to throw new NotImplementedException(), and the //TODO will be removed. -- To view, visit http://gerrit.ovirt.org/3374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2338676527984f58f3119e9ba61a9f05e29837af Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
