Maor Lipchuk has posted comments on this change. Change subject: core:Add support for disk alias to commands ......................................................................
Patch Set 4: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java Line 203: ImagesHandler.setDiskAlias(diskImage.getDisk(), getVm()); switched the command lines. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java Line 37: VM vm; You are right, the existing code was misleading The logic (which were used to calculate image description) is if vm was not fetched from the contatinee id, then fetch it from the vm id, and the vm id was set with the contatiner id, for some reason. any how will change. -- To view, visit http://gerrit.ovirt.org/3071 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2d37172f294f43b2955b915e6b17d8b1d322860 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
