Omer Frenkel has posted comments on this change.
Change subject: core: Refactor method to handler
......................................................................
Patch Set 4: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 108: log.errorFormat("Disk object is null, the suggested
default disk alias to be used is %1$s",
why this is an error? maybe warn? when this is called? and when do we expect it
to happen?
Line 113: diskAlias = getDefaultDiskAlias(diskPrefix, new
Integer(disk.getInternalDriveMapping()).toString());
any reason to take a string, convert to integer and then back to string?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
Line 106: List<Integer> vmDisks =
LinqUtils.foreach(vm.getDiskMap().keySet(), new Function<String, Integer>() {
i think its a good opportunity to change this linq to a regular for,
and while at it, combine the next for into this one.
--
To view, visit http://gerrit.ovirt.org/3069
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76c979644b22aa1528cd061342c3e335a31121c7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
