Shireesh Anjal has posted comments on this change. Change subject: engine: Start Gluster Volume Includes following related to the commands for "Start Gluster Volume" - New BLL Action and parameters - New VDS Command and parameters - Audit Log messages and severities - App Errors - VDSM Errors ......................................................................
Patch Set 1: (2 inline comments) Couple of inline comments. .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java Line 189: public Map<String, Object> glusterVolumeStart(String volumeName, String force); Should "force" be passed as a Boolean ? .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java Line 973: return new StatusOnlyReturnForXmlRpc(vdsServer.glusterVolumeStart(volumeName, force.toString())); I think the "force" variable should be passed to the vdsServer method as it is, instead of converting to string. -- To view, visit http://gerrit.ovirt.org/3215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dbaf59ed905d4a1aafae741e60799517a1818ce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesub...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
