Yair Zaslavsky has posted comments on this change.
Change subject: core: run once - boot order param is not sent for CD-ROM device
......................................................................
Patch Set 1: (2 inline comments)
Two minor comments on code.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 335: for (int i = 0; i < devices.size(); i++) {
I recommend you also use a foreach loop here, if possible.
Line 339: if (StringUtils.map2String((Map<String,
String>) o).indexOf(vmDevice.getDeviceId().toString()) > 0) {
I would recommend to use String.contains
--
To view, visit http://gerrit.ovirt.org/3308
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09cbd13278247e079bfb9cc1f032bd03e84cd43e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
