Yair Zaslavsky has posted comments on this change. Change subject: core: duplicate cdrom created when cloning a VM from snapshot ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java Line 85: String isoPath=vmBase.getiso_path(); You gave a good explanation in the commit message, can you add more comments based on it to the code (so we will not have to look for the commit msg , and see the good explanation also in the code?) Line 87: boolean hasAlreadyCD = ((DbFacade.getInstance().getVmDeviceDAO().getVmDeviceByVmIdTypeAndDevice(vmBase.getId(), VmDeviceType.DISK.getName(), VmDeviceType.CDROM.getName())).size() > 0); general comment: instead of .size() > 0 please use ! collection.isEmpty() -- To view, visit http://gerrit.ovirt.org/3303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77ef4a87ec636f5e01140b47b8fd82ca671d9539 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
