Michael Kublin has posted comments on this change. Change subject: core: extract common plug/unplug canDo checks ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) Use inheritance instead of static, explanation in comments .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PlugUnplugCommons.java Line 5: import org.ovirt.engine.core.compat.Version; You don't need a following class, all those methods should be moved to VmCommand class, especially that your class that uses those methods is extend of VmOperationCommandBase. -- To view, visit http://gerrit.ovirt.org/3202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28f8a6749989f04c13195c7dddb69b93bc4a0d4f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
