Eli Mesika has posted comments on this change.
Change subject: packaging: remoteDB support
......................................................................
Patch Set 1: (8 inline comments)
....................................................
File backend/manager/dbscripts/dbfunctions.sh
Line 250: # Checks that the extension IS installed
IS => is
Line 251: CMD1="SELECT extname FROM pg_extension WHERE extname='uuid-ossp';"
please give descriptive names , do not use numbering to distinguish between
variables, it is not readable
Line 252: RES1=`execute_command "${CMD1}" ${DATABASE} ${SERVERNAME} ${PORT}`
same
Line 254: CMD2="SELECT name FROM pg_available_extensions WHERE
name='uuid-ossp';"
same
Line 255: RES2=`execute_command "${CMD2}" ${DATABASE} ${SERVERNAME} ${PORT}`
same
Line 257: # First, check that uuid is not installed
" uuid-ossp" => why is the heading blank character? if the select returns it ,
use instead the sql trim function to remove it
Line 258: if [ "$RES1" == " uuid-ossp" ]; then
IMHO the condition should be = not ==
" uuid-ossp" => why is the heading blank character? if the select returns it ,
use instead the sql trim function to remove it
Line 261: if [ "$RES2" != " uuid-ossp" ]; then
same
--
To view, visit http://gerrit.ovirt.org/3110
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff1f8c87836609ec1bd558bd3cd7e9a51e2db22
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
