Omer Frenkel has posted comments on this change.
Change subject: searchbackend: Change disk search to use new view
......................................................................
Patch Set 4: (2 inline comments)
partial reviewed
....................................................
File backend/manager/dbscripts/create_views.sql
Line 134: FROM images_storage_domain_view
consider selecting directly from the tables, as this view makes lots of joins,
that im not sure are needed
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java
Line 327: ParameterizedRowMapper<DiskImage> mapper = new
ParameterizedRowMapper<DiskImage>() {
i think we should use the mapper that is used in other places
--
To view, visit http://gerrit.ovirt.org/3060
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3c660035e731ebf1f4182838e09f2d34eff93d1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
