Omer Frenkel has posted comments on this change.
Change subject: core : Introducing RemoveDiskCommand
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
Line 36: public class RemoveDiskCommand<T extends RemoveDiskParameters> extends
CommandBase<T> {
no need to lock?
Line 214: ActionGroup.CONFIGURE_VM_STORAGE));
it doesn't make sense to require CONFIGURE_VM_STORAGE action-group on a storage
domain.. until disk permissions implemented, maybe require it on the vm for
vms, and COPY_TEMPLATE on template
--
To view, visit http://gerrit.ovirt.org/3022
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife638580e33f45c75d1f92816fcf69d7cdf3be2c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
