Livnat Peer has posted comments on this change. Change subject: core: Add grant_mode attribute to permissions entity ......................................................................
Patch Set 1: (1 inline comment) 1. the RESTAPI is missing 2. please add a can do action check to validate a user is not giving permissions and marking them as system permissions. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/PermissionGrantMode.java Line 16: I think that Manual and Automatic reflect better the purpose of this Enum. User and System are already used in the context of permission for marking role types. (user and Admin). -- To view, visit http://gerrit.ovirt.org/2978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia638481671662c2216929a7db1e4ac80cb4119d4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
