Yair Zaslavsky has posted comments on this change.
Change subject: core: Fix illegal images handling
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
Line 174: for (DiskImage diskImage :
getDiskImageDao().getAllSnapshotsForVmSnapshot(snapshotId)) {
i agree. this might end up to be too much logic for db side
--
To view, visit http://gerrit.ovirt.org/2919
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8defc2660cf9404a088050dd10df8632d79f1de5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
