Maor Lipchuk has posted comments on this change.

Change subject: core: Add quota name to VM and disks views
......................................................................


Patch Set 2:

I don't think so, 
since quota name is a transient field (It is only fetched by the view) so it 
can't be saved or update through those DAOs.
That means I can't count on it when I'm using equals or hash method.
The only thing that can be checked is if the fetch works fine with it, and it 
maps correctly, and that is already being taking care of in the DAO tests.

--
To view, visit http://gerrit.ovirt.org/2819
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53279164f7abaffd538f4318811bb821681f04e5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to