Michael Pasternak has posted comments on this change. Change subject: DO NOT SUBMIT api: Adding support for clone vm from snapshot ......................................................................
Patch Set 33: (3 inline comments) .................................................... File backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResourceTest.java Line 34: import org.ovirt.engine.api.restapi.util.SessionHelper; please revert changes in this file. .................................................... File backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java Line 736: expect(entity.getStaticData()).andReturn(vmStatic).anyTimes(); this expectations relevant for your use-case only, no need for all tests to see them, please move them to your method which will extend expectations for setUpEntityExpectations() .................................................... Commit Message Line 11: (previously, all Snapshot mappers mapped from DiskImage business entity) well done!, only clean-ups left: please revert re-formating of the code, i suggest you format only changed lines and turn off imports sorting -- To view, visit http://gerrit.ovirt.org/2302 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8b8285cfe193a1d501c28af042021f4649bc299 Gerrit-PatchSet: 33 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
