Moti Asayag has posted comments on this change.
Change subject: core : Introducing of AttachDiskToVmCommand
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
Line 12: public class AttachDiskToVmCommand<T extends UpdateVmDiskParameters>
extends AbstractDiskVmCommand<T> {
Shouldn't the command acquire lock for the Disk image ? It seems like a
potential race of a disk to be added for 2 VMs when isn't marked as shared.
Line 19: if (getParameters().getDiskInfo().getPlugged() == null) {
getParameters().getDiskInfo() is repeated 11 time, would it preffered to set it
as class variable ? Or at least be assigned to local parameters ?
--
To view, visit http://gerrit.ovirt.org/2732
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie85b25a20d205a3e31e7a5fb18aa2e3d6e35fe76
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
