Maor Lipchuk has posted comments on this change. Change subject: engine: Fix automatic default quota name. ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaHelper.java Line 143: return (suffixQuotaName > 0) ? quotaDefaultName + "_" + suffixQuotaName.toString() : quotaDefaultName; I know that regarding + operator, the compiler already taking care of it, and there should be no major performance difference between the two. But for readable purposes it might be better to use the String.format, will be changed. -- To view, visit http://gerrit.ovirt.org/2530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82212ea40a25d4a1405d68e3b17771fe26e2b61a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
