Yair Zaslavsky has posted comments on this change. Change subject: DO NOT SUBMIT common: CopyImage parameters ......................................................................
Patch Set 10: (1 inline comment) MoveOrCopyImageGroup is an overkill for what is required in case of both AddVmFromSnapshot and AddVmFromTemplate - Copy (vdsm-wise) is always collapse, for example (so no need for the boolean flag in the parameters). The change in hierarchy was done in order to distinguish between snapshot related commands and image related commands. Maybe MoveOrCOpyImageGroup should execute copy image command as well (I'm referring here to the code duplication issue). .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CopyImageParameters.java Line 18: Done -- To view, visit http://gerrit.ovirt.org/2297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3709374312c0851eca0689c02c8b12de69b921f9 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
