Mike Kolesnik has posted comments on this change.
Change subject: engine-core: unused private methods
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EvenlyDistributeVDComparer.java
Line 32: // private boolean isVdsGoingToBeOverCommited(VDS vds, VM vm) {
I don't see how you're not allowed to remove commented code...
Anyway, we have SCM so if someone wants to find this unused code he can look
for it there, but I would rather not have additional comments lying around
since who will know to remove them?
--
To view, visit http://gerrit.ovirt.org/582
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80553066fda747d195f972333979b0091f133ce9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
