Yair Zaslavsky has posted comments on this change. Change subject: engine-core: [autorecovery] rename SchedulerUtil ......................................................................
Patch Set 5: No score Regarding the OnTimer issue - At first it also looked strange to me, but I believe this will be even better. @OnTimer annotation let us define some sort of "aliasing" other method names for the timer, but still - we had to look for the method, and to find if its annotated with OnTimer, and get compare the annotation value. By providing directly a method name, we just need to perform "getMethod" using the method name and that's it - this even provides a slight (?) performance improvement. Since we never used the "aliasing" (provided strings that are equal to the method name) I see no reason to continue and use the @OnTimer mechanism. I will be more than glad to hear more opinions on this. -- To view, visit http://gerrit.ovirt.org/2140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I382d9b397778fc9f3eea02c82a5ed602753ae284 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
