Moti Asayag has posted comments on this change. Change subject: common: Adding query params ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmConfigurationBySnapshotQueryParams.java Line 12: private Guid SnapshotSourceId; please keep class organized by: 1. static variable 2. data member 3. c'tor 4. other methods also please keep java naming convention and start variable name with a lower case. -- To view, visit http://gerrit.ovirt.org/2166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5464f303ef3197815d02331b984bd3844507ac4c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
