Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin: Tab UI reuse concept
......................................................................
webadmin: Tab UI reuse concept
This patch presents the concept of reusing tab UI by creating
custom widgets that are used within main/sub tab Views. Reusing
View content (widgets) instead of whole Views allows us to stay
flexible in terms of application architecture (since Views are
architectural components of the Model-View-Presenter pattern).
There are basically two kinds of tabs, whose UI should be reused
within different applications (WebAdmin and UserPortal):
1) form-based tabs
- AbstractModelBoundFormWidget is the base class for custom
widgets that are Editors of the given UiCommon model
2) table-based tabs
- AbstractModelBoundTableWidget is the base class for custom
widgets that use SimpleActionTable to render UiCommon list
models
Naming convention is '<model>Form' for form-based widgets, and
'<model>Table' for table-based widgets. This patch includes
implementations of both kinds of widgets:
- VmGeneralModelForm (VM General sub-tab)
- VmInterfaceListModelTable (VM NIC sub-tab)
Note: AbstractModelBoundTableWidget-based widgets should be used
within Views that extend AbstractSubTabTableWidgetView. This View
is designed for integration with AbstractModelBoundTableWidget,
in contrast with original AbstractSubTabTableView that creates
and handles the SimpleActionTable directly.
Change-Id: I235e423b450df4a7ca249cc39ec30a7cd1ba736c
---
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/MainTableHeaderlessResources.java
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/MainTableResources.java
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/SubTableHeaderlessResources.java
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/SubTableResources.java
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractSubTabTableWidgetView.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/ImageUiCommandButtonDefinition.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/UiCommandButtonDefinition.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/UiMenuBarButtonDefinition.java
R
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/BooleanLabel.java
R
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/BooleanRenderer.java
R
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/RxTxRateRenderer.java
R
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/SumUpRenderer.java
R
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/RxTxRateColumn.java
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/SumUpColumn.java
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/AbstractModelBoundFormWidget.java
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/AbstractModelBoundTableWidget.java
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceListModelTable.java
R
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/TabCellTable.css
R
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/TabCellTableHeaderless.css
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/action/UserPortalButtonDefinition.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/action/UserPortalImageButtonDefinition.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AbstractMainTabTableView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AbstractSubTabTableView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RoleView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/SystemPermissionView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageVmBackupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/SubTabVirtualMachineGeneralView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/SubTabVirtualMachineGeneralView.ui.xml
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/SubTabVirtualMachineNetworkInterfaceView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/SubTabVirtualMachineSnapshotView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/action/WebAdminButtonDefinition.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/action/WebAdminImageButtonDefinition.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/action/WebAdminMenuBarButtonDefinition.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java
D
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/SumUpColumn.java
38 files changed, 621 insertions(+), 430 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/20/2120/1
--
To view, visit http://gerrit.ovirt.org/2120
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I235e423b450df4a7ca249cc39ec30a7cd1ba736c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
