Maor Lipchuk has posted comments on this change. Change subject: engine: Create default unlimited quota for DC ......................................................................
Patch Set 5: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java Line 40: createUnlimitedQuotaForEveryUser(defaultStoragePoolQuota); No, the quota can be also in not disabled status, but since each storage pool must have at least one quota, there must be a creation of a new quota. Since we don't change the everyone consumers to the quota when we update the DC with quota enforced status, why not keeping uniform behaviour? .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java Line 43: storage_pool storagePool = DbFacade.getInstance().getStoragePoolDAO().get(getStoragePool().getId()); sure, will be in the next patch set. -- To view, visit http://gerrit.ovirt.org/1334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib963feff1216b4792b5981e602b4aea96149207e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
