Maor Lipchuk has posted comments on this change.
Change subject: engine: Add/edit quota commands
......................................................................
Patch Set 4: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddQuotaCommand.java
Line 16: public class AddQuotaCommand<T extends QuotaCRUDParameters> extends
CommandBase<T> {
Interesting thaght, it could work.
but what's wrong using it like this.
I think that by using this kind of style, I leave my self the option to extend
the parameter file in the future, and also since all the commands are using
this style, it is understandable enough to use.
Line 49: VdcObjectType.Quota);
will change to quotaId also in the update and remove command
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateQuotaCommand.java
Line 63: private void setQuotaParameter(T parameters) {
Yes, I think replacing this function with setQuota in the constructor will be
enough.
--
To view, visit http://gerrit.ovirt.org/1328
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d932a312a51aafb9c4f80a549314b3c53890841
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
