Moti Asayag has posted comments on this change. Change subject: tools: Adding multiple selection of string values ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/StringMultipleValueHelper.java Line 32: if (validValues.isEmpty() || value.equals("")) { Does it mean that if there is no valid values configured, any value is valid ? -- To view, visit http://gerrit.ovirt.org/2059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02e78041b642450caa505d9011ebddf36401b491 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches