Barak Azulay has posted comments on this change.
Change subject: packaging: add sequences to engine-setup (plugins step 2/3)
......................................................................
Patch Set 6: (2 inline comments)
Please fix the comments
....................................................
File Makefile
Line 137: chmod 755
$(PREFIX)/usr/share/ovirt-engine/scripts/engine_sequences.py
name engine_seaquence implies something else.
I would go with setup_seaquence or ...
....................................................
File packaging/fedora/setup/engine_sequences.py
Line 20: raise TypeError("step's function should be of list type
instead of %s" % type(functions))
if you do a validity check, you may as well want to check that each function is
actually callable
--
To view, visit http://gerrit.ovirt.org/1643
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66b2ac6255f47e8e09d0b0e9972858864bcbd7f3
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ronen Angluster <rangl...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Idan Mansano <imans...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Ronen Angluster <rangl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
