Mike Kolesnik has posted comments on this change. Change subject: core: DO NOT SUBMIT DAL: removing of DiskImageTemplate ......................................................................
Patch Set 7: (1 inline comment) .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java Line 89: VmEntityType vmEntityType = VmEntityType.valueOf(entityType); My personal pereference is to inline such code, since the variable is not really needed. This also goes for the rest of the file. -- To view, visit http://gerrit.ovirt.org/1568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I977154fab3b9f64f3c4fb5c7fbcd3db27ea7be52 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
