Michael Kublin has posted comments on this change. Change subject: core: Task Manager Adds Jobs clean up manager ......................................................................
Patch Set 2: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryCleanupManager.java Line 30: Integer cleanupFrequency = Config.<Integer> GetValue(ConfigValues.JobCleanupRateInMinutes); also we have this in a lot places, but it is ugly, the class still is not initialized, but we passed it to some other place Line 52: .getJobDao() These is ugly, also sometimes create a strange errors when working with java.uitl.Date Please think about using System.currenttimeinmillis (whatever) + minutes * 60 * 1000 and after that new Date(value) -- To view, visit http://gerrit.ovirt.org/1300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1da5a2001aa1ce65a50c63d7654585cb39061d0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
