Moti Asayag has submitted this change and it was merged. Change subject: core: Refactor of VdsDynamic.getSupportedVersion ......................................................................
core: Refactor of VdsDynamic.getSupportedVersion The patch refactors the VdsDynamic: It removes the usage of the LogComapt from within the class to loose the dependency on the Compat project (and specifically on the LogCompat). By that, the possible thrown exception as a result of the version parsing will be handled by the caller for the methods: HandleVdsVersionCommand. Since VdsDynamic.getSupportedENGINESVersionsSet and VdsDynamic.getSupportedClusterVersionsSet shares the exact logic, a common message was extracted. Change-Id: Ic8d0d9ac09cdbca563515774382711fad4913452 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VersionSupport.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java 3 files changed, 69 insertions(+), 34 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8d0d9ac09cdbca563515774382711fad4913452 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
