Omer Frenkel has posted comments on this change. Change subject: core: Remove ImagesSyncronizer and related code ......................................................................
Patch Set 2: (2 inline comments) .................................................... File backend/manager/dbscripts/upgrade/03_01_0240_remove_ImagesSyncronizer_related_data.sql Line 7: WHERE log_type IN (800, 801, 802, 803, 804, 805, 806, 807, 808); i think we should delete by log_type_name as these id's might be reused and i'm not sure when this script may run .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java Line 1042: huh? -- To view, visit http://gerrit.ovirt.org/1344 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdeef253b718764f25bf3c94e861ea0a5e1bebbe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
