Yair Zaslavsky has posted comments on this change.
Change subject: engine-core: fixing NPE in importVmTemplateCommand
......................................................................
Patch Set 1: Fails
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
Line 295: for(Map.Entry<Guid, Guid> set :
imageToDestinationDomainMap.entrySet()) {
Tried applying your change on my local work.
Doesn't work - the map is empty. Why does this occur? What code is supposed to
fill it? (I am using webadmin + my local work + rebased on your fix).
I did a local fix of checking if the imageToDestinationDomainMap is empty - if
not - I proceed with the current ode you suggested. If it is empty - I perform
similar flow on vmTemplate.getDIskImageMap();
--
To view, visit http://gerrit.ovirt.org/1408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8393803f807412bb6b58b8b7656db0d89a0cc2f2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jonathan Choate <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
