Vojtech Szocs has uploaded a new change for review. Change subject: webadmin: Application window focus handling reworked ......................................................................
webadmin: Application window focus handling reworked Before this patch, GridController's toForeground/toBackground methods would only be called for main list models, and not for other (e.g. detail) list models. This is now handled globally within DataBoundTabModelProvider for all UiCommon SearchableListModels. 1. Created ApplicationFocusManager: class responsible for hooking to application window focus/blur events, and propagating this information to other system components through the event bus (window focus hook was previously part of WebAdmin MainSectionView) 2. Added boolean flag 'isIE' to ClientAgentType for easy IE detection (remember that ClientAgentType is a GIN-managed injectable singleton) 3. Each DataBoundTabModelProvider now listens for window focus change events and calls GridController's toForeground/toBackground methods appropriately. When the root CommonModel instance is null (user is not logged in), or the given SearchableListModel has its timer stopped (e.g. via EnsureAsyncSearchStopped method), toForeground and toBackground methods have no effect on that model. 3. In AbstractMainTabWithDetailsPresenter, removed @ProxyEvent method that handled window focus change events, and related classes/methods which are now unnecessary. Change-Id: Icc88476f9bb0a5c7df34316ae6b640ccc8416cd4 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ApplicationFocusChange.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ApplicationFocusManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/ClientAgentType.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DataBoundTabModelProvider.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ReceivesFocus.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/refresh/AbstractRefreshManager.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/UserPortalDataBoundModelProvider.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/MainSectionPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AbstractMainTabWithDetailsTableView.java D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/ApplicationFocusChange.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/MainSectionView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/SimpleActionTable.java 15 files changed, 140 insertions(+), 164 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/96/1396/1 -- To view, visit http://gerrit.ovirt.org/1396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icc88476f9bb0a5c7df34316ae6b640ccc8416cd4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
