Moti Asayag has posted comments on this change.

Change subject: core: Change VDSBrokerFrontend return value of remove
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VDSBrokerFrontendImpl.java
Line 101:         IVdsAsyncCommand command = null;
when you put it like this...

this should be a single liner: 
return _asyncRunningCommands.remove(vmId);

will fix it next patch

--
To view, visit http://gerrit.ovirt.org/1297
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22c1f558be62e86f6fcd72ffdaf033a5ba163b2e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to