Ofer Schreiber has posted comments on this change. Change subject: Packaging: Updated ambiguous text message (#784206) ......................................................................
Patch Set 1: Fails (2 inline comments) Two comments inside .................................................... Commit Message Line 11: Description: No need for "Description" .................................................... File packaging/fedora/setup/output_messages.py Line 144: WARN_LOW_MEMORY="There is less than %s GB of available free memory on this machine.\nIt is recommended to have at least %s GB of available memory to run the Engine Manager." % (basedefs.CONST_WARN_MEMORY_GB, basedefs.CONST_WARN_MEMORY_GB) the official name is oVirt-Engine (and not Engine Manager). Better separate it to another variable (and check if we user rhevm/RHEV Manager) in other variables. -- To view, visit http://gerrit.ovirt.org/1291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia89016c6bc5ac423b781c4daba07447988c68b30 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
