Doron Fediuck has posted comments on this change. Change subject: core : "User is already logged in" error when trying to login" ......................................................................
Patch Set 1: (2 inline comments) Michael, some minor issues not related to your fix, but should be fixed. See inline. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java Line 152: addCanDoActionMessage(VdcBllMessages.USER_CANNOT_LOGIN_SESSION_MISSING); can you please replace the order of above line and the one below? So we have- 1. authenticated=false; 2. addCanDoActionMessage(... In this case if something goes wrong authenticated flag is off. Line 196: HandleAuthenticationError(result.getErrorMessages()); can you please replace the order of above line and the one below? So we have- 1. authenticated=false; 2. HandleAuthenticationError(... In this case if something goes wrong authenticated flag is off. -- To view, visit http://gerrit.ovirt.org/1268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83c34e2ed694eada9db7776a86944e8faeab8e60 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.0 Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
