Omer Frenkel has posted comments on this change. Change subject: engine-core: Multiple storage domains when importing VM ......................................................................
Patch Set 1: (4 inline comments) some small comments .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java Line 416: }); ligically i'd say addVmToDb ends here, and from here is images handling Line 437: Map<Guid, Guid> imageDomainMap = getParameters().getImageMap(); the idea was to minimize cache in commands classes, for some use case that canDoAction and execution may run for the same command with different instances, im not sure how much this is enforced, though. Line 646: addInterfacesFromTemplate(); why another method is needed? .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveOrCopyParameters.java Line 21: private Map<Guid, Guid> imageMap = new HashMap<Guid, Guid>(); maybe better to call it imageStorageMap, just to be clearer? as it map 2 guids, which may be confusing -- To view, visit http://gerrit.ovirt.org/1067 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67ebc1b402194897cf2ed12f45228153e2efe153 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jonathan Choate <jcho...@redhat.com> Gerrit-Reviewer: Jonathan Choate <jcho...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
