Eli Mesika has posted comments on this change. Change subject: core : Adding utility class for VmDevice - VmDeviceUtils ......................................................................
Patch Set 3: (3 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java Line 15: private final static String HIGH_VIDEO_MEM = "65536"; Is there a point to put in config something that is currently HARD CODED? i.e. you can not configure it to any value apart from there two .... Line 71: DbFacade.getInstance().getVmDeviceDAO().remove(list.get(0).getId()); Done Line 228: device.setBootOrder(bootOrder++); Done -- To view, visit http://gerrit.ovirt.org/1164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4956e963f46491be7c72804cceb76eee40838037 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
