Doron Fediuck has posted comments on this change. Change subject: engine-config: support setting a password from file or ask interacively ......................................................................
Patch Set 1: (1 inline comment) Roy, We talked about it and this is running over existing properties. We need to use a proper parsing, and if the existing one is not good enough than we should improve it. .................................................... File backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigCLIParser.java Line 273: System.setProperty(e.getKey(), e.getValue()); As I explained to you in the past, this is running over existing system properties, and should not be used. Please use an alternative of proper command line parsing as we do today. -- To view, visit http://gerrit.ovirt.org/86 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1cdd5aa8fafaa497ec93298846961c46ed9c5e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
