Ihor Radchenko <[email protected]> writes: > Björn Kettunen <[email protected]> writes: > >>> Any particular reason why you don't use the code I suggested? >> >> Mostly because I didn't see your reply until I posted the updated patch. >> >> But after reading the suggested code now it's also that it didn't seem >> obvious to me that it can be shortened that much essentially you do the >> same thin as I'm already doing but without the check if a table contains >> any data. > > Is that check necessary though? org-clock-get-table-data always returns > non-empty list.
The list doesn't have to be empty but it can return a list that contains a list without any entries, the when-let takes care of that. >> Also I think it's easier to read wrap the table merging and the >> expanding of files with their archives into separate functions. >> The only thing that bothers me that I don't know how to call the >> get-table-data-with-archives function without the use of a lambda when >> passing both the parameters and the file. > > I am not sure why using lambda is a problem. It's not really but it's just a bit annoying to wrap the call into a lamda just to be able to pass more arguments to a function. Anyway it's fine. >> What's the difference between using nthcdr 2 and cddr? > > The latter is slightly faster. That's it. > >> Instead of car and then nthcdr or cddr I could probably also do cddar. > > Sure, you can.
