branch: elpa/helm commit 20cce89fc605a8d61a11608b845c6401549dce23 Author: Thierry Volpiatto <thie...@posteo.net> Commit: Thierry Volpiatto <thie...@posteo.net>
Try to clarify what we are doing with helm-command-prefix 1) No need to declare helm-command-prefix with defvar, fset later is making the symbol AFAIU. 2) Using define-prefix-command is not needed as it fset helm-command-prefix to an empty map and set helm-command-prefix (var) to this same empty map; And just after this, we fset helm-command-prefix to helm-command-map and then setq it to helm-command-map. So AFAIU we only have to fset helm-command-prefix to helm-command-map. --- helm-global-bindings.el | 5 ----- 1 file changed, 5 deletions(-) diff --git a/helm-global-bindings.el b/helm-global-bindings.el index 5f4ff98ca7..b51cad9511 100644 --- a/helm-global-bindings.el +++ b/helm-global-bindings.el @@ -84,12 +84,7 @@ (define-key map (kbd "@") 'helm-list-elisp-packages) map)) -;; Don't override the keymap we just defined with an empty -;; keymap. This also protect bindings changed by the user. -(defvar helm-command-prefix) -(define-prefix-command 'helm-command-prefix) (fset 'helm-command-prefix helm-command-map) -(setq helm-command-prefix helm-command-map) ;;; Menu