branch: externals/hyperbole commit 74ad94b11478fb3003c03a56832c84ccb37b22e2 Author: Mats Lidell <mats.lid...@lidells.se> Commit: GitHub <nore...@github.com>
Silence byte compilation warnings for interaction-log (#298) --- ChangeLog | 6 ++++++ hypb.el | 29 ++++++++++++++++++++++++----- 2 files changed, 30 insertions(+), 5 deletions(-) diff --git a/ChangeLog b/ChangeLog index 35113e2102..20005090ac 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2023-01-22 Mats Lidell <ma...@gnu.org> + +* hypb.el: Add variable and function declarations for package + interaction-log to silence byte compilation warnings. + (hypb:activate-interaction-log-mode): Use cl-pushnew. + 2023-01-20 Mats Lidell <ma...@gnu.org> * Remove docstring warnings. diff --git a/hypb.el b/hypb.el index f51de655cc..912d87cd8b 100644 --- a/hypb.el +++ b/hypb.el @@ -3,7 +3,7 @@ ;; Author: Bob Weiner ;; ;; Orig-Date: 6-Oct-91 at 03:42:38 -;; Last-Mod: 10-Dec-22 at 00:52:04 by Mats Lidell +;; Last-Mod: 22-Jan-23 at 16:57:36 by Mats Lidell ;; ;; Copyright (C) 1991-2022 Free Software Foundation, Inc. ;; See the "HY-COPY" file for license information. @@ -17,7 +17,7 @@ ;;; Other required Elisp libraries ;;; ************************************************************************ -(eval-and-compile (mapc #'require '(compile hversion hact locate))) +(eval-and-compile (mapc #'require '(compile hversion hact locate cl-lib))) ;;; ************************************************************************ ;;; Public variables @@ -51,6 +51,26 @@ It must end with a space." (declare-function helm-apropos "ext:helm") (declare-function devdocs-lookup "ext:devdocs") +;; interaction-log +(defvar ilog-buffer-name) +(defvar ilog-display-state) +(defvar ilog-idle-time) +(defvar ilog-insertion-timer) +(defvar ilog-print-lambdas) +(defvar ilog-self-insert-command-regexps) +(defvar ilog-truncation-timer) +(defvar interaction-log-mode) +(defvar interaction-log-mode-hook) + +(declare-function ilog-note-buffer-change "ext:interaction-log") +(declare-function ilog-post-command "ext:interaction-log") +(declare-function ilog-record-this-command "ext:interaction-log") +(declare-function ilog-show-in-other-frame "ext:interaction-log") +(declare-function ilog-timer-function "ext:interaction-log") +(declare-function ilog-toggle-view "ext:interaction-log") +(declare-function ilog-truncate-log-buffer "ext:interaction-log") +(declare-function interaction-log-mode "ext:interaction-log") + ;;; ************************************************************************ ;;; Public functions ;;; ************************************************************************ @@ -78,7 +98,7 @@ This displays a clean log of Emacs keys used and commands executed." (setq ilog-print-lambdas 'not-compiled) ;; Omit display of some lower-level Hyperbole commands for cleaner logs - (mapc (lambda (cmd-str) (pushnew (format "^%s$" cmd-str) ilog-self-insert-command-regexps)) + (mapc (lambda (cmd-str) (cl-pushnew (format "^%s$" cmd-str) ilog-self-insert-command-regexps)) '("hyperbole" "hui:menu-enter")) ;; Redefine the mode to display commands on post-command-hook rather @@ -99,8 +119,7 @@ This displays a clean log of Emacs keys used and commands executed." (setq ilog-truncation-timer (run-at-time 30 30 #'ilog-truncate-log-buffer)) (setq ilog-insertion-timer (run-with-timer ilog-idle-time ilog-idle-time #'ilog-timer-function)) - (message "Interaction Log: started logging in %s" ilog-buffer-name) - (easy-menu-add ilog-minor-mode-menu)) + (message "Interaction Log: started logging in %s" ilog-buffer-name)) (remove-hook 'after-change-functions #'ilog-note-buffer-change) (remove-hook 'post-command-hook #'ilog-record-this-command) (remove-hook 'post-command-hook #'ilog-post-command)