branch: externals/zuul
commit 4a4cebac0507197bce584797d4822fd84ab75d17
Author: Niklas Eklund <niklas.ekl...@posteo.net>
Commit: Niklas Eklund <niklas.ekl...@posteo.net>
Update useage of compilation-minor-mode
Previous implementation had intermittent problems as well as
unnecessary font-lock code.
---
zuul.el | 27 +++++++++++++--------------
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/zuul.el b/zuul.el
index 439fa4ff45..144e38db4e 100644
--- a/zuul.el
+++ b/zuul.el
@@ -42,6 +42,7 @@
(require 'ansi-color)
(require 'comint)
+(require 'compile)
(require 'project)
(eval-when-compile (require 'rx))
(require 'subr-x)
@@ -349,16 +350,18 @@ the parameter to pass to it. Examples of query functions
are:
(if (not build-output)
(message "Build has no output")
(with-current-buffer (get-buffer-create buffer)
- (let ((inhibit-read-only t))
- (setq-local default-directory project-root)
- (erase-buffer)
- (insert build-output)
- (zuul-log-mode)
- (setq zuul--current-build zuul--build)
- (setq zuul--current-builds zuul--builds)
- (goto-char (point-max))
- (select-window
- (display-buffer buffer
zuul-build-display-buffer-action))))))))))
+ (setq-local default-directory project-root)
+ (erase-buffer)
+ (insert build-output)
+ (zuul-log-mode)
+ (setq zuul--current-build zuul--build)
+ (setq zuul--current-builds zuul--builds)
+ (goto-char (point-min))
+ (compilation-minor-mode t)
+ (compilation--ensure-parse (point-max))
+ (goto-char (point-max))
+ (select-window
+ (display-buffer buffer zuul-build-display-buffer-action)))))))))
(cl-defun zuul-get-builds (&key
change
@@ -1149,11 +1152,7 @@ Optionally provide extra parameters PARAMS, PARSER,
METHOD, BUFFER or HEADERS."
(setq zuul--project-files (zuul--project-files))
(setq-local compilation-parse-errors-filename-function #'zuul--locate-file)
(setq-local imenu-create-index-function #'zuul--imenu-index)
- (compilation-minor-mode)
- (setq-local font-lock-defaults '(compilation-mode-font-lock-keywords t))
(add-hook 'eldoc-documentation-functions #'zuul--eldoc-function nil t)
- (read-only-mode)
- (font-lock-mode)
(zuul--highlight-cmd))
(provide 'zuul)
