branch: elpa/emacsql commit 373975cbccf7776af771e23f86043b236a330702 Author: Jonas Bernoulli <jo...@bernoul.li> Commit: Christopher Wellons <well...@nullprogram.com>
Remove types from cl-defgeneric arguments Emacs 29 now warns: "Non-symbol arguments to cl-defgeneric". One could argue that specifying the type is useful to the human reader; then again cl-defgeneric without a body doesn't implement a default method, so doing it is also misleading. Closes #94. --- emacsql.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/emacsql.el b/emacsql.el index b26d97b368..cbc1de6486 100644 --- a/emacsql.el +++ b/emacsql.el @@ -136,7 +136,7 @@ MESSAGE should not have a newline on the end." ;;; Sending and receiving -(cl-defgeneric emacsql-send-message ((connection emacsql-connection) message) +(cl-defgeneric emacsql-send-message (connection message) "Send MESSAGE to CONNECTION.") (cl-defmethod emacsql-send-message :before @@ -171,7 +171,7 @@ MESSAGE should not have a newline on the end." (emacsql-type-map (or mask emacsql-type-map))) (concat (apply #'emacsql-format (emacsql-prepare sql) args) ";"))) -(cl-defgeneric emacsql ((connection emacsql-connection) sql &rest args) +(cl-defgeneric emacsql (connection sql &rest args) "Send SQL s-expression to CONNECTION and return the results.") (cl-defmethod emacsql ((connection emacsql-connection) sql &rest args)