branch: externals/corfu commit b9bc65d967faff7eddc3155780d3848cd872512a Author: Daniel Mendler <m...@daniel-mendler.de> Commit: Daniel Mendler <m...@daniel-mendler.de>
corfu-popupinfo: Fix todo --- extensions/corfu-info.el | 2 +- extensions/corfu-popupinfo.el | 7 ++----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/extensions/corfu-info.el b/extensions/corfu-info.el index c9bf1b96a3..615e5d6a3d 100644 --- a/extensions/corfu-info.el +++ b/extensions/corfu-info.el @@ -87,7 +87,7 @@ (goto-char (point-min)) (forward-line (1- (cdr loc)))) (set-window-start nil (point))))) - (user-error "Location is unknown"))) + (user-error "No location available"))) ;; Emacs 28: Do not show Corfu commands with M-X (put #'corfu-info-location 'completion-predicate #'ignore) diff --git a/extensions/corfu-popupinfo.el b/extensions/corfu-popupinfo.el index 77beac627d..657574cc36 100644 --- a/extensions/corfu-popupinfo.el +++ b/extensions/corfu-popupinfo.el @@ -329,11 +329,8 @@ the candidate popup, its value is 'bottom, 'top, 'right or 'left." (setf face-remapping-alist (copy-tree face-remapping-alist) (alist-get 'default face-remapping-alist) 'corfu-popupinfo)) (unless (eq corfu-popupinfo--toggle 'init) - (message - ;; TODO support custom functions, don't hard code the error! - (if (eq corfu-popupinfo--function #'corfu-popupinfo--get-documentation) - "No documentation available" - "Location is unknown"))) + (message "No %s available" + (last (split-string (symbol-name corfu-popupinfo--function) "-+")))) (corfu-popupinfo--hide) (setq doc-changed nil coords-changed nil corfu-popupinfo--toggle nil))) (when (or doc-changed coords-changed)