branch: externals/denote commit 2e5ae8b804ce621124c7ce4fafb0b9843f0d48c1 Author: Jean-Philippe Gagné Guay <jeanphilippe...@gmail.com> Commit: Jean-Philippe Gagné Guay <jeanphilippe...@gmail.com>
Fix denote-dired-rename-markd-files - keywords should be allowed to be nil. - The answer to yes-or-no-p should not yield the error "No marked files" if the answer is no. --- denote.el | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/denote.el b/denote.el index f310a81e17..63ea89fd62 100644 --- a/denote.el +++ b/denote.el @@ -1553,24 +1553,24 @@ The operation does the following: if the given file has the appropriate file type extension (per the user option `denote-file-type')." (interactive nil dired-mode) - (if-let ((marks (dired-get-marked-files)) - (keywords (denote--keywords-prompt)) - ((yes-or-no-p "Add front matter or rewrite front matter of keywords (buffers are not saved)?"))) - (progn - (dolist (file marks) - (let* ((dir (file-name-directory file)) - (id (denote--file-name-id file)) - (file-type (denote--filetype-heuristics file)) - (title (denote--retrieve-title-or-filename file file-type)) - (extension (file-name-extension file t)) - (new-name (denote--format-file - dir id keywords (denote--sluggify title) extension))) - (denote--rename-file file new-name) - (when (denote--writable-and-supported-p new-name) - (if (denote--edit-front-matter-p new-name file-type) - (denote--rewrite-keywords new-name keywords file-type) - (denote--add-front-matter new-name title keywords id file-type))))) - (revert-buffer)) + (if-let ((marks (dired-get-marked-files))) + (let ((keywords (denote--keywords-prompt))) + (when (yes-or-no-p "Add front matter or rewrite front matter of keywords (buffers are not saved)?") + (progn + (dolist (file marks) + (let* ((dir (file-name-directory file)) + (id (denote--file-name-id file)) + (file-type (denote--filetype-heuristics file)) + (title (denote--retrieve-title-or-filename file file-type)) + (extension (file-name-extension file t)) + (new-name (denote--format-file + dir id keywords (denote--sluggify title) extension))) + (denote--rename-file file new-name) + (when (denote--writable-and-supported-p new-name) + (if (denote--edit-front-matter-p new-name file-type) + (denote--rewrite-keywords new-name keywords file-type) + (denote--add-front-matter new-name title keywords id file-type))))) + (revert-buffer)))) (user-error "No marked files; aborting"))) (define-obsolete-function-alias