branch: elpa/orgit commit 8ba66a5779b5a55d29b6a568d2d1e54b928cbb21 Author: Jonas Bernoulli <jo...@bernoul.li> Commit: Jonas Bernoulli <jo...@bernoul.li>
Use and-let* for side-effects --- orgit.el | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/orgit.el b/orgit.el index b555c3db37..7af35b0195 100644 --- a/orgit.el +++ b/orgit.el @@ -373,7 +373,8 @@ store links to the Magit-Revision mode buffers for these commits." (cond ((eq major-mode 'magit-revision-mode) (orgit-rev-store-1 magit-buffer-revision)) ((derived-mode-p 'magit-mode) - (when-let ((revs (magit-region-values 'commit))) + (when-let* ((revs (magit-region-values 'commit))) + ;; Cannot use and-let* because of debbugs#31840. (mapc #'orgit-rev-store-1 revs) t)))) @@ -426,9 +427,9 @@ store links to the Magit-Revision mode buffers for these commits." ((member orgit-remote remotes) orgit-remote)))) (if remote (if-let ((link - (or (when-let ((url (magit-get "orgit" gitvar))) + (or (and-let* ((url (magit-get "orgit" gitvar))) (format-spec url `((?r . ,rev)))) - (when-let ((url (magit-get "remote" remote "url")) + (and-let* ((url (magit-get "remote" remote "url")) (format (cl-find-if (lambda (elt) (string-match (car elt) url))