branch: externals/org-remark
commit 02d7b562653e532afc18c872a26f65a6076fb814
Author: Noboru Ota <m...@nobiot.com>
Commit: Noboru Ota <m...@nobiot.com>
fix: tracking does not save for the first file
The issue was that org-marginalia-global-tracking mode did not start
tracking unless there is at least one already being tracked...
This was a defect; it could not start tracking anything unless you
manually edit `org-marginalia-tracking-file`.
Fixed this by checking the global minor mode on or off instead.
---
.gitignore | 2 ++
README.org | 8 ++------
org-marginalia.el | 6 +++++-
3 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/.gitignore b/.gitignore
index 47f208c0b0..e2b91d9138 100644
--- a/.gitignore
+++ b/.gitignore
@@ -2,5 +2,7 @@
*.bak
*.log
+*.elc
+
/demo/2020-12-24_10-00-13.png
/demo/Copy of 2020-12-24_10-00-13.png
diff --git a/README.org b/README.org
index 0afe81eeb3..cdd96b616d 100644
--- a/README.org
+++ b/README.org
@@ -62,12 +62,6 @@ non-nil, Org-marginalia will add an ID property to the file
level. This is mainl
- [[#feedback][Feedback]]
- [[#license][License]]
- [[#marginalia-for-org-marginaliael][Marginalia for org-marginalia.el]]
- - [[#deleted-notes][Deleted Notes]]
- - [[#deleted-notes-on-jit-lock-register][Deleted Notes on jit-lock-register]]
- - [[#org-marginalia-load][org-marginalia-load]]
- - [[#set-buffer-modified-p][set-buffer-modified-p]]
- - [[#overlay-put][overlay-put]]
- - [[#make-overlay-beg-end-nil-front-advance][(make-overlay beg end nil
'FRONT-ADVANCE)]]
- [[#local-variables][Local Variables]]
:END:
@@ -315,6 +309,8 @@ This work is licensed under a GPLv3 license. For a full
copy of the licese, refe
* Marginalia for ~org-marginalia.el~
:PROPERTIES:
:marginalia-source-file: ~/local-repos/org-marginalia/org-marginalia.el
+:marginalia-source-file: ~/src/org-marginalia/org-marginalia.el
+:TOC: :depth 0
:END:
This section is used as a demonstration and a collection of my ideas for this
package.
diff --git a/org-marginalia.el b/org-marginalia.el
index 0140da0bed..b4750f1b9e 100644
--- a/org-marginalia.el
+++ b/org-marginalia.el
@@ -247,6 +247,10 @@ buffer or quit Emacs. When you re-launch Emacs, ensure to
turn on
(beg (car (cdr highlight)))
(end (cdr (cdr highlight))))
(org-marginalia-mark beg end id)))))
+ ;; Tracking
+ (when org-marginalia-global-tracking-mode
+ (add-to-list 'org-marginalia-files-tracked
+ (abbreviate-file-name (buffer-file-name))))
(setq org-marginalia-loaded t)))
(defun org-marginalia-save ()
@@ -273,7 +277,7 @@ in the current buffer. Each highlight is represented by an
overlay."
(org-entry-get (overlay-start h) "ID" 'INHERIT))))
(org-marginalia-save-single-highlight h title source-path orgid)))
;; Tracking
- (when org-marginalia-files-tracked
+ (when org-marginalia-global-tracking-mode
(add-to-list 'org-marginalia-files-tracked
(abbreviate-file-name (buffer-file-name))))))
