branch: externals/embark commit 33b47bb8999f8c7d67e9d1e04668e421e3c7246f Author: Omar Antolín <omar.anto...@gmail.com> Commit: Omar Antolín <omar.anto...@gmail.com>
Revert binding default action to <return> Yes, it's annoying if the enter key doesn't run the default action, but few modes have a binding for <return>, so it's not really a big problem and it had an even more annoying consequence: the completing-read prompter said, "the default action is so nice, I think I'm going to list it twice!". --- embark.el | 1 - 1 file changed, 1 deletion(-) diff --git a/embark.el b/embark.el index a057762..50f5de3 100644 --- a/embark.el +++ b/embark.el @@ -938,7 +938,6 @@ If CYCLE is non-nil bind `embark-cycle'." (let ((map (make-sparse-keymap)) (default-action (embark--default-action type))) (define-key map [13] default-action) - (define-key map [return] default-action) (when-let ((cycle-key (and cycle (embark--cycle-key)))) (define-key map cycle-key #'embark-cycle)) (when embark-help-key