branch: elpa/popup commit 24619f5ac453bdc11fef965900fffc8e70004731 Merge: e742014 38156f0 Author: Jen-Chieh Shen <jcs090...@gmail.com> Commit: GitHub <nore...@github.com>
Merge pull request #126 from phst/mapcar Don’t use ‘mapcar’ for side effect --- popup.el | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/popup.el b/popup.el index 4fee3ac..49a7052 100644 --- a/popup.el +++ b/popup.el @@ -245,11 +245,11 @@ ITEM is not string." Optional argument REP is the replacement string of non-displayable character." (unless rep (setq rep "")) (let ((result "")) - (mapcar (lambda (ch) - (setq result (concat result - (if (char-displayable-p ch) (string ch) - rep)))) - str) + (mapc (lambda (ch) + (setq result (concat result + (if (char-displayable-p ch) (string ch) + rep)))) + str) result)) (cl-defun popup-make-item (name