branch: elpa/php-mode
commit 904313508d2884c8cd39a15d509cc89f42a2951d
Author: USAMI Kenta <[email protected]>
Commit: USAMI Kenta <[email protected]>
Ship php-flymake.el and php-align.el in the package
Neither file was listed in Eask's `files', so neither ended up in the
built package. php-mode.el requires php-flymake at load time, which
makes the result unusable:
$ eask package /tmp/dist
$ tar xf /tmp/dist/php-mode-1.26.1.tar && cd php-mode-1.26.1
$ emacs -Q --batch -L . --eval "(require 'php-mode)"
Eager macro-expansion failure: (file-missing "Cannot open load file"
"No such file or directory" "php-flymake")
php-flymake.el has been missing from the list since it was added in
dc67eae, and php-align.el since the move into lisp/ in cc63080. CI
never caught it because `eask test ert' runs against the source tree,
where both files are on the load path either way.
php-align.el is not required by anything -- users load it themselves --
but it is just as much part of the package, and shipping it is the point
of it being here.
With both listed, the built package loads and php-flymake is defined.
The two `rx' warnings php-flymake.el now contributes to `eask compile'
are pre-existing.
---
Eask | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Eask b/Eask
index b1a157d6f2..deef9331f4 100644
--- a/Eask
+++ b/Eask
@@ -16,11 +16,13 @@
"lisp/php-indent.el"
"lisp/php-keywords.el"
"lisp/php-face.el"
+ "lisp/php-flymake.el"
"lisp/php-format.el"
"lisp/php-project.el"
"lisp/php-local-manual.el"
"lisp/php-ide-phpactor.el"
"lisp/php-ide.el"
+ "lisp/php-align.el"
"lisp/php-mode-debug.el")
(script "test" "echo \"Error: no test specified\" && exit 1")
