branch: elpa/sly
commit b01993cf1d6626d541998a77dd802483c9687789
Author: Artyom Bologov <[email protected]>
Commit: GitHub <[email protected]>
Close #697: Address style warning in SLYNK::CLOSE-CHANNEL
The compilers used when developing this probably took the &KEY in a
generic function method to mean &ALLOW-OTHER-KEYS and let it slide.
Modern compilers seem to think that is bad style. They're not wrong,
but &ALLOW-OTHER-KEYS is not great either. So use an explicit kwarg.
* slynk/slynk.lisp (close-channel): Introduce a FORCE argument
Co-authored-by: João Távora <[email protected]>
---
slynk/slynk.lisp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/slynk/slynk.lisp b/slynk/slynk.lisp
index 9e1f29b76f4..2ae6db32e2d 100644
--- a/slynk/slynk.lisp
+++ b/slynk/slynk.lisp
@@ -521,7 +521,8 @@ corresponding values in the CDR of VALUE."
(defun channel-thread-id (channel)
(slynk-backend:thread-id (channel-thread channel)))
-(defmethod close-channel (channel &key)
+(defmethod close-channel (channel &key force)
+ (declare (ignore force))
(let ((probe (find-channel (channel-id channel))))
(cond (probe (setf (channels) (delete probe (channels))))
(t (error "Can't close invalid channel: ~a" channel)))))
